Eliminate media query in favor of a bootstrap class #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
eliminate-media-query
branch
from
e1a13a3
to
7f8f2a1
Compare
jcoyne
added a commit
to sul-dlss/stanford-arclight
that referenced
this pull request
Jun 12, 2024
See upstream change at projectblacklight/arclight#1547
seanaery
approved these changes
Jun 13, 2024
|
Thanks for these helpful changes. Looks like this one just got merge-conflicted with the previously merged PR because they change the same file in about the same spot. I think if you rebase on |
jcoyne
force-pushed
the
eliminate-media-query
branch
from
7f8f2a1
to
2ca9551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for the downstream consumers to customize (by overriding the template)